Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JobsManager handling importUsers response payload #492

Merged
merged 1 commit into from
May 28, 2020

Conversation

davidpatrick
Copy link
Contributor

@davidpatrick davidpatrick commented May 27, 2020

Currently TokensManager and UserManager return response data, while Jobs is returning the whole response. To avoid a breaking change, and make the experience consistent with the Jobs manager, we are adding a new function importUsersJob that will extract the data from the response

Follow up to #491
Closes #467

@davidpatrick davidpatrick requested a review from a team May 27, 2020 22:36
@davidpatrick davidpatrick changed the title Update JobsManager JobsManager handling importUsers response payload May 27, 2020
package.json Outdated Show resolved Hide resolved
src/management/JobsManager.js Outdated Show resolved Hide resolved
test/management/jobs.tests.js Show resolved Hide resolved
Currently Tokens and User manager return response data, while Jobs is returning the request.  To avoid a breaking change, and make the experience consistent with the Jobs manager, we are adding a new function `importUsersJob` that will extract the data from the response
@lbalmaceda lbalmaceda merged commit a36b017 into master May 28, 2020
@lbalmaceda lbalmaceda deleted the davidpatrick-patch-1 branch May 28, 2020 14:07
@davidpatrick davidpatrick added this to the v2.26.0 milestone May 29, 2020
@davidpatrick davidpatrick mentioned this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CH: Added small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ManagementClient#importUsers returns Promise of IncomingMessage
2 participants